Added tests for capturing createdAt values and list function behavior #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cv/created-at-tests
branch
from
ccec863 to
cda14df
Compare
alexrisch
reviewed
Feb 21, 2024
| // BUG - List returns in Reverse Chronological order on iOS | ||
| // and Chronological order on Android | ||
| const first = isIos() ? 1 : 0 | ||
| const second = isIos() ? 0 : 1 |
There was a problem hiding this comment.
Do we have a tracking issue for this?
There was a problem hiding this comment.
#276, and there's two more issues linked in the description 👍
alexrisch
approved these changes
Feb 21, 2024
|
🎉 This PR is included in version 1.28.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.30.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for checking the order returned from
list(),listGroups(), andlistAll(),stream(),streamGroups(), andstreamAll(), and comparescreatedAtfield of items returned from list functions tocreatedAtfield of items returned bycreateGroup/Conversationfunctions.My recommendation is to merge these new tests with the comments they have about where behavior is currently inconsistent between android and iOS. We can then update the tests as the below issues are fixed.
Issues Documented in the tests:
listGroups issues: See #276
conversations.listGroups()returns in reverse chronological on iOS, and chronological order on AndroidcreatedAtfield returned bylistGroups()does not match thecreatedAtof group returned bycreateGroupfunction on Android when the group was created by someone other than the client who calledlistGroups()list / listAll issues: See #277
conversations.listAll()sets values tocreatedAtfor groups that do not match the values ofcreatedAtreturned fromcreateGroupfunction.list()andlistAll()methods for conversations returns in Chronological order for iOS and reverse Chronological order for Androidstream/streamAll issue: See #278
createAtvalue of a group returned does not match thecreatedAtvalue of the group returned by the createGroup() method on Android only.