Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base64 for group id #262

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

nplasterer
Copy link
Contributor

Lets just convert the group id to hex like we do everywhere else in the code.

@nplasterer nplasterer self-assigned this Feb 14, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 14, 2024 23:05
@cameronvoell cameronvoell self-requested a review February 14, 2024 23:56
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I added one more spot for base64 to hex 👍

@nplasterer nplasterer merged commit 5efb429 into np/ios-streaming Feb 15, 2024
3 of 4 checks passed
@nplasterer nplasterer deleted the np/remove-base64-id branch February 15, 2024 15:39
Copy link
Contributor

🎉 This PR is included in version 1.27.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.28.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.30.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants