Add/remove groups #250
Add/remove groups #250
Conversation
Added functionality for add remove groups
| } | ||
| val group = findGroup(clientAddress, id) | ||
|
|
||
| runBlocking { group?.addMembers(peerAddresses) } |
There was a problem hiding this comment.
In the long-term it might be good to return an error if the group is not found, here and in the other methods, but doesn't need to block this PR
| // throw new Error( | ||
| // 'num groups for bob should be 0, but it is ' + bobGroups.length | ||
| // ) | ||
| // } |
There was a problem hiding this comment.
I noticed that when this is uncommented that the test fails because the size of bobClient.conversations.listGroups() is still 1 after he is removed.
@richardhuaaa Is this expected that groups you have been removed from still are returned from listGroups()? If so, what is the proper way for someone to detect that they have been removed from a group?
There was a problem hiding this comment.
Hey @cameronvoell, yes with the current code the group and message history will remain in your database, but you should stop receiving updates. @neekolas is working on a way to notify the platform/app layer that a user has been removed from a group, but it is not ready yet.
Is this expected that groups you have been removed from still are returned from listGroups()?
Alex was also confused about this, lmk if this seems unintuitive from the perspective of API design or if there's a better way to expose this. I don't think we've necessarily optimized around developer experience so far
There was a problem hiding this comment.
For now it's expected, a user will see past messages but not future
There was a problem hiding this comment.
@richardhuaaa I think from a UX perspective it's a bit confusing
From a developer perspective it makes sense if the purpose is to allow the developer freedom to clear the messages in some way.
Meaning if I as an integrating developer want to "remove" the user from the chat and clear messages I can, or if I want them to just stop receiving updates I have the options to do either
There was a problem hiding this comment.
Hey cameronvoell, yes with the current code the group and message history will remain in your database, but you should stop receiving updates. neekolas is working on a way to notify the platform/app layer that a user has been removed from a group, but it is not ready yet.
Alex was also confused about this, lmk if this seems unintuitive from the perspective of API design or if there's a better way to expose this. I don't think we've necessarily optimized around developer experience so far
@richardhuaaa Sounds like it's just unintuitive because that one piece is not finished yet. Think the only real missing piece is a recommended way for someone to be notified that theyve been blocked, once we have that we should be able to handle the rest on the SDK side. Thanks for confirming!
There was a problem hiding this comment.
Agreed. I don't think it's our job to decide what to do after the user has been removed. Some apps may want to continue showing the conversation and history (just with the ability to interact removed), some won't. We just need to surface that information to developers. I'll work on adding that today.
|
🎉 This PR is included in version 1.27.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.28.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.30.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added functionality for add remove groups