Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity signer #232

Merged
merged 15 commits into from
Feb 16, 2024
Merged

Identity signer #232

merged 15 commits into from
Feb 16, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Feb 1, 2024

This exposes a function to sign messages from identities. Will help unlock frames.
Also adds a way to fetch the public key bundle.

@nplasterer nplasterer self-assigned this Feb 1, 2024
@neekolas
Copy link
Contributor

neekolas commented Feb 1, 2024

I realized there's actually one more thing I'll need to make this work. It looks like RN doesn't have a way to get the PublicKeyBundle for the current user. We'll also need that to assemble the Frame post payload

@nplasterer
Copy link
Contributor Author

I think they do but it's named differently https://github.com/xmtp/xmtp-react-native/blob/main/src/lib/Client.ts#L305-L315 is this what you need? @neekolas

@neekolas
Copy link
Contributor

neekolas commented Feb 1, 2024

That gets the PrivateKeyBundle, which I guess does included the public key bundle. Would be nice to not have to touch the private keys, but that would be fine as a short term fix.

Maybe a few weeks from now we end up re-implementing all of this in Rust and we don't have to worry about it.

@nplasterer
Copy link
Contributor Author

Ahh okay I can definitely get the public keys easy then.

@nplasterer nplasterer marked this pull request as ready for review February 2, 2024 04:50
@nplasterer nplasterer requested a review from a team as a code owner February 2, 2024 04:50
src/index.ts Show resolved Hide resolved
nplasterer and others added 2 commits February 2, 2024 08:06
Additional methods for frames client
@alexrisch
Copy link
Contributor

Simulator Screenshot - iPhone 15 Pro - 2024-02-14 at 17 40 14

Alex Risch added 2 commits February 15, 2024 15:36
Corrected Android build and functionality
Tests
iOS
Android
updated frame client
@alexrisch
Copy link
Contributor

alexrisch commented Feb 15, 2024

Screenshot 2024-02-15 at 3 49 42 PM

example/src/tests.ts Outdated Show resolved Hide resolved
example/package.json Outdated Show resolved Hide resolved
@cameronvoell cameronvoell self-requested a review February 16, 2024 19:37
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good, nice work!

@alexrisch alexrisch merged commit 763d037 into main Feb 16, 2024
4 of 5 checks passed
@alexrisch alexrisch deleted the np/frames-signer branch February 16, 2024 19:44
Copy link
Contributor

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants