-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity signer #232
Identity signer #232
Conversation
I realized there's actually one more thing I'll need to make this work. It looks like RN doesn't have a way to get the |
I think they do but it's named differently https://github.com/xmtp/xmtp-react-native/blob/main/src/lib/Client.ts#L305-L315 is this what you need? @neekolas |
That gets the PrivateKeyBundle, which I guess does included the public key bundle. Would be nice to not have to touch the private keys, but that would be fine as a short term fix. Maybe a few weeks from now we end up re-implementing all of this in Rust and we don't have to worry about it. |
Ahh okay I can definitely get the public keys easy then. |
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt
Outdated
Show resolved
Hide resolved
… np/frames-signer
Additional methods for frames client
7b01c38
to
8707a93
Compare
Additional methods for frames client
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt
Outdated
Show resolved
Hide resolved
Corrected Android build and functionality
Tests iOS Android updated frame client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests look good, nice work!
🎉 This PR is included in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This exposes a function to sign messages from identities. Will help unlock frames.
Also adds a way to fetch the public key bundle.