fix: Revert Java Version Upgrade #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Jan 23, 2024
| @@ -66,17 +66,17 @@ afterEvaluate { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdkVersion safeExtGet("compileSdkVersion", 34) | |||
| compileSdkVersion safeExtGet("compileSdkVersion", 31) | |||
|
|
|||
| def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION | |||
| if (agpVersion.tokenize('.')[0].toInteger() < 8) { | |||
There was a problem hiding this comment.
This call is strange to me cause you have to be on AGP 8 for version 17. 🤔 But now that we are dropping it back to 11 not an issue. Maybe what needed to happen was an else statement that set to 17 if above AGP 8 otherwise 11.
Revert java version upgrade until React Native 0.73 is more widly used
alexrisch
force-pushed
the
ar/fix-revert-java-upgrade
branch
from
4e42497 to
17e943c
Compare
|
🎉 This PR is included in version 1.24.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.24.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert java version upgrade until React Native 0.73 is more widly used