Fix Custom Content Type Decryption #209
Conversation
…base64 string back to bytes
There was a problem hiding this comment.
Worked for me, nice fix!
The buffer package is pretty lightweight and well-supported so there shouldn't be any issues adding it to the rn sdk.
As a minor size improvement, we may be able to replace the 'buffer' dependency with base64-js which is a dependency in buffer that is used for base64 decoding(link) and has its own method for converting from base64 string to byte array.
An alternative would be react-native-quick-base64 if we ever want to aim for performance improvements, say if decoding large files in custom content is every a thing, but that package is less popular.
I think a good path would be to merge with the buffer dependency to get this working and evaluate less popular alternatives as potential improvements 👍
|
🎉 This PR is included in version 1.23.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
To pass data from native iOS and Android to RN we parse the information into json strings. To make Android match iOS we have to hand roll a lot of this. Because our test wasn't thorough I missed the content field in the json blob initially. We also missed the step to convert the base64 back into bytes after coming across the wire.