Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe #202

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update ReadMe #202

merged 1 commit into from
Jan 9, 2024

Conversation

alexrisch
Copy link
Contributor

@alexrisch alexrisch commented Jan 5, 2024

Updated readme for yarn add
Updated read me to include babel plugin steps

Fixes: #181

@alexrisch alexrisch requested a review from jhaaaa as a code owner January 5, 2024 16:04
@alexrisch alexrisch requested a review from a team January 9, 2024 18:42
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @fabriguespe since it's a doc change.

@alexrisch do you think you could also update the CODEOWNERS file in this PR to swap Jha for Fabri. I believe he owns the repo readmes now. 🙏

Updated readme for yarn add
Updated read me to include babel plugin steps
@alexrisch
Copy link
Contributor Author

LGTM! cc @fabriguespe since it's a doc change.

@alexrisch do you think you could also update the CODEOWNERS file in this PR to swap Jha for Fabri. I believe he owns the repo readmes now. 🙏

Updated!

@alexrisch alexrisch merged commit 5b43135 into main Jan 9, 2024
4 of 5 checks passed
@alexrisch alexrisch deleted the ar/update-readme branch January 9, 2024 19:37
Copy link
Contributor

🎉 This PR is included in version 1.23.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Export namespace should be first transformed by @babel/plugin-transform-export-namespace-from.
2 participants