Custom content types #155
Merged
Custom content types #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This solution is only suitable for very basic content types. For things like remote attachments, a native component will still be necessary for performance.
… custom-content-types
nplasterer
approved these changes
Nov 27, 2023
…eact-native into custom-content-types
…eact-native into np/custom-content-types-android
… custom-content-types
Android side of custom content types
nplasterer
reviewed
Nov 30, 2023
nplasterer
reviewed
Nov 30, 2023
…eact-native into custom-content-types
nplasterer
approved these changes
Dec 2, 2023
…registered on the client
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability to use custom content types on iOS (Kotlin support to follow).
This PR does not replace any of the existing content types that already ship with SDK. Instead it changes
DecodedMessage#contentto be a function rather than a property. The function will either return the same values it does today or the decoded content from a JS content codec.If we dig this overall approach then we can look into replacing the hard coded codecs in a couple places, but I don't know what that would look like for codecs that require a native component (like attachments).
Basic usage can be seen in the tests: