Use Conversation#send instead of new method for sending with custom c…

…ontent types
xmtp · Nov 30, 2023 · 3b69fb1 · 3b69fb1
1 parent caee68c
commit 3b69fb1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/example/src/tests.ts b/example/src/tests.ts
@@ -691,7 +691,7 @@ test('register and use custom content types', async () => {
   const bobConvo = await bob.conversations.newConversation(alice.address)
   const aliceConvo = await alice.conversations.newConversation(bob.address)
 
-  await bobConvo.sendWithJSCodec(12, ContentTypeNumber)
+  await bobConvo.send(12, { contentType: ContentTypeNumber })
 
   const messages = await aliceConvo.messages()
   assert(messages.length === 1, 'did not get messages')

diff --git a/src/lib/Conversation.ts b/src/lib/Conversation.ts
@@ -1,6 +1,11 @@
 import { DecodedMessage } from './DecodedMessage'
 import * as XMTP from '../index'
 import { ConversationContext, PreparedLocalMessage } from '../index'
+
+export type SendOptions = {
+  contentType?: XMTP.ContentTypeId
+}
+
 export class Conversation<ContentTypes> {
   client: XMTP.Client<ContentTypes>
   createdAt: number
@@ -81,7 +86,7 @@ export class Conversation<ContentTypes> {
     }
   }
 
-  async sendWithJSCodec<T>(
+  private async _sendWithJSCodec<T>(
     content: T,
     contentType: XMTP.ContentTypeId
   ): Promise<string> {
@@ -111,7 +116,11 @@ export class Conversation<ContentTypes> {
    *
    * @todo Support specifying a conversation ID in future implementations.
    */
-  async send(content: any): Promise<string> {
+  async send(content: any, opts?: SendOptions): Promise<string> {
+    if (opts && opts.contentType) {
+      return await this._sendWithJSCodec(content, opts.contentType)
+    }
+
     try {
       if (typeof content === 'string') {
         content = { text: content }