Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for more frequent keepalives #387

Merged
merged 3 commits into from
May 2, 2024
Merged

Allow for more frequent keepalives #387

merged 3 commits into from
May 2, 2024

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented May 2, 2024

tl;dr

  • Adds an option related to KeepAlives to the node GRPC server. This allows clients to be more aggressive in sending keepalive messages.

What does this mean?

keepalive.EnforcementPolicy.MinTime

// MinTime is the minimum amount of time a client should wait before sending
// a keepalive ping.

@neekolas neekolas requested review from humanagent and alexrisch May 2, 2024 20:43
@neekolas neekolas enabled auto-merge (squash) May 2, 2024 20:46
@neekolas neekolas mentioned this pull request May 2, 2024
Merged
@neekolas neekolas merged commit 9b84f9e into main May 2, 2024
3 checks passed
@neekolas neekolas deleted the nm/add-server-keepalive-params branch May 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

@rygine rygine rygine approved these changes

@humanagent humanagent Awaiting requested review from humanagent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neekolas @rygine @alexrisch