Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for validation service #378

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Add support for validation service #378

merged 5 commits into from
Apr 24, 2024

Conversation

richardhuaaa
Copy link
Contributor

@richardhuaaa richardhuaaa commented Apr 23, 2024

This just implements the wrappers for the validation service, and plumbs it into the identity service. I will be out for the next two weeks, feel free to modify or land on my behalf.

I wasn't able to complete the remaining piece of the identity service, this is what needs to be done in the next PR:

  1. Implement the TODO's here and here, using the logic described here. The validation can be done by calling into the handler introduced in this PR.
  2. Implement this read

@richardhuaaa richardhuaaa changed the title Rich/validate associations Add support for validation service Apr 23, 2024
@richardhuaaa richardhuaaa marked this pull request as ready for review April 23, 2024 18:17
Copy link
Collaborator

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe to build on top of. Think we can merge and keep going to actually integrate the validation service into PublishIdentityUpdate

@insipx insipx merged commit 2df0a53 into main Apr 24, 2024
3 checks passed
@insipx insipx deleted the rich/validate-associations branch April 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants