Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first two unused indexes #376

Merged
merged 10 commits into from
May 10, 2024
Merged

Remove first two unused indexes #376

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4538890
Remove first two unused indexes
neekolas Apr 19, 2024
6107c1e
Don't make it concurrent
neekolas Apr 22, 2024
0d3000e
Just use select 1 for down
neekolas Apr 22, 2024
f7d71b2
Drop sort index too
neekolas Apr 22, 2024
af467ee
Merge branch 'main' into 04-19-remove_first_two_unused_indexes
neekolas Apr 26, 2024
4ec60f8
Merge branch 'main' into 04-19-remove_first_two_unused_indexes
neekolas May 9, 2024
a0646c6
Update PR
neekolas May 9, 2024
861eb30
Rename migration
neekolas May 9, 2024
bd183b3
Remove if not exists
neekolas May 9, 2024
b51c458
Fix splitting
neekolas May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/migrations/messages/20240419172419_remove-unused-indexes-pt-1.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
SET statement_timeout = 0;

--bun:split

CREATE INDEX CONCURRENTLY IF NOT EXISTS message_pubsubTopic_idx ON public.message (pubsubTopic);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without CONCURRENTLY, does the server start up extremely slowly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also take a lock of the entire table and block reads

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having problems actually running concurrent index drops in a migration (for some reason it is trying to run the migration in a tx, which is not allowed). I might just make this non-concurrent but manually drop the index concurrently in prod first.

4 changes: 4 additions & 0 deletions pkg/migrations/messages/20240419172419_remove-unused-indexes-pt-1.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
SET statement_timeout = 0;

DROP INDEX CONCURRENTLY IF EXISTS messageindex;
neekolas marked this conversation as resolved.
Show resolved Hide resolved
DROP INDEX CONCURRENTLY IF EXISTS message_pubsubtopic_idx;
Loading