Use a shared nats server #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Mar 28, 2024
neekolas
commented
Mar 28, 2024
This reverts commit 8b635a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue with
SubscribeAlland group messages. Both the legacy and the MLS APIs create their own nats servers. That means that the servers cannot talk to one another. This only becomes an issue withSubscribeAll, which is expected to receive messages from both servers.SubscribeAllNotes
There is a bunch of half-finished work on the underlying streaming infrastructure. We are so close to being able to remove Nats altogether, which would be a big win for both performance and maintainability. We should prioritize that work at some point.