Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore centralized subscription handler #361

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Restore centralized subscription handler #361

merged 9 commits into from
Feb 27, 2024

Conversation

richardhuaaa
Copy link
Contributor

@richardhuaaa richardhuaaa commented Feb 27, 2024 •
edited
Loading

  1. Restore the centralized subscription handler (Add RPC requests limits & implement centralized subscription handler #354)
  2. Remove the RPC request limits that were added - to reduce number of variables (can add separately)
  3. Include @neekolas 's additional logging
  4. Log lots of info when a subscription channel is full, but don't close it
  5. 4x the backlog length for subscribeAll
  6. Set minBacklogLength for normal subscriptions

tsachiherman and others added 7 commits February 26, 2024 22:36
@tsachiherman @richardhuaaa
Add RPC requests limits & implement centralized subscription handler (#…
b023c75 
…354)

* add reuqests limit.

* update per feedback 1.

* update per peer review.

* update testing.

* update

* update

* rollback change.

* additional rollback.

* few small tweaks.

* update test

* update tests

* update

* add wait.

* add minBacklogLength

* update

* update

* update per peer feedback

* cherry pick Steven's fix

* fix lint

* add docker hub deploy for branch.

* Deploy this branch to dev for testing

* fix bug in subscribed topic count

* remove temp deploy workflows.

---------

Co-authored-by: Steven Normore <[email protected]>
@neekolas @richardhuaaa
Add back MLS subscriptions
810a39a
@neekolas @richardhuaaa
Add more logging
42ce5b8
@richardhuaaa
Disable limits in service.go
abd845c
@richardhuaaa
Log when channel is full, but don't close it
41c0699
@richardhuaaa
Increase backlog size for allTopics subscriptions
6842127
@richardhuaaa
Set minBacklogBufferLength
a326375
@richardhuaaa richardhuaaa marked this pull request as ready for review February 27, 2024 07:20
@neekolas
Copy link
Collaborator

This at least has a much better shot of rolling out smoothly than the original PR. And if it doesn't, we'll have logs telling us why.

Let's give it a try in the morning.

@neekolas neekolas merged commit b49b8ef into main Feb 27, 2024
3 checks passed
@neekolas neekolas deleted the rich/restore-subscription branch February 27, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardhuaaa @neekolas @tsachiherman