Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
Subscribe2
we allow a client to update their subscription by passing an updated list of the topics they are interested in. The subscription metrics were incrementing the total subs by the length of the list instead of the delta between the old and new, causing our subscriptions metric to inflate.Notes
One caveat to this approach is that we only set the
xmtp_subscribe_topics_length
based on the original request, not any updates. That seems better than observing a new metric every time the subscription changes by 1.