Fix ciphertext validation

xmtp · Oct 24, 2023 · cd38308 · cd38308
1 parent 6b57691
commit cd38308
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/api/message/v3/service.go b/pkg/api/message/v3/service.go
@@ -263,8 +263,9 @@ func validatePublishWelcomesRequest(req *proto.PublishWelcomesRequest) error {
 		if welcome == nil || welcome.WelcomeMessage == nil {
 			return status.Errorf(codes.InvalidArgument, "invalid welcome message")
 		}
-		ciphertext := welcome.WelcomeMessage.GetV1().Ciphertext
-		if len(ciphertext) == 0 {
+
+		v1 := welcome.WelcomeMessage.GetV1()
+		if v1 == nil || len(v1.Ciphertext) == 0 {
 			return status.Errorf(codes.InvalidArgument, "invalid welcome message")
 		}
 	}