Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HMAC keys in Node SDK #764

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add support for HMAC keys in Node SDK #764

merged 2 commits into from
Jan 2, 2025

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jan 2, 2025

Summary

  • Upgraded node bindings
  • Added hmacKeys method to Conversations for retrieving HMAC keys of all conversations
  • Added HmacKey type export
  • Added tests

@rygine rygine requested a review from a team as a code owner January 2, 2025 19:18
Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: c5e0b8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/node-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rygine rygine requested a review from a team as a code owner January 2, 2025 19:19
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2025

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 755c962
Status: ✅  Deploy successful!
Preview URL: https://8397a2fc.xmtp-js.pages.dev
Branch Preview URL: https://rygine-node-sdk-hmac.xmtp-js.pages.dev

View logs

Copy link
Contributor

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you. Can we bump the sdk version?

@rygine
Copy link
Collaborator Author

rygine commented Jan 2, 2025

Wonderful, thank you. Can we bump the sdk version?

the changeset will bump the version in a subsequent PR auto-generated in CI.

@rygine rygine merged commit d84932a into main Jan 2, 2025
22 of 23 checks passed
@rygine rygine deleted the rygine/node-sdk-hmac branch January 2, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants