Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdks workspace, update README #677

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add sdks workspace, update README #677

merged 6 commits into from
Oct 10, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Oct 10, 2024

Summary

  • Added sdks workspace, move SDKs into it
  • Update README
  • Removed deprecated launch.json
  • Removed unused setting in settings.json

@rygine rygine requested review from a team as code owners October 10, 2024 10:48
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: f9a51f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2024

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9a51f3
Status: ✅  Deploy successful!
Preview URL: https://9df530b7.xmtp-js.pages.dev
Branch Preview URL: https://rygine-cleanup.xmtp-js.pages.dev

View logs

@@ -5,6 +5,7 @@
"workspaces": [
"content-types/*",
"packages/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is packages/* needed anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good callout, yep! i'm going to migrate some packages from other repos into this one and use the packages workspace for them.

@rygine rygine merged commit ee9da40 into main Oct 10, 2024
20 checks passed
@rygine rygine deleted the rygine/cleanup branch October 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants