Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate content types into repo #676

Merged
merged 318 commits into from
Oct 10, 2024
Merged

Migrate content types into repo #676

merged 318 commits into from
Oct 10, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Oct 9, 2024

Summary

This PR brings in the content types from xmtp-js-content-types, preserving git history. This is part of the effort to centralize all JavaScript related code into a single repository.

Other notable changes:

  • The single experimental content type is not included in this migration
  • Format checking via prettier has been refactored to centralize config and dependencies
    • The JS SDK and MLS client are now using the official web prettier config
  • Some dev dependencies were upgraded
  • Added GitHub workflow for content types
  • Added upload-service to docker-compose.yml for remote attachment tests

Notes

Once this merges, the xmtp-js-content-types repo will be archived and a link pointing to this repo will be added to the root README.

The NPM token used for publishing will also need an update to include the content type packages.

rygine and others added 30 commits July 10, 2023 10:48
Add schema to Reaction content type
Docs: Update repo readme and link content type READMEs to their related XIPs
Docs: Update URLs for content type feedback
Read receipt content type overview
@rygine rygine requested review from a team as code owners October 9, 2024 20:31
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 814a45d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 814a45d
Status: ✅  Deploy successful!
Preview URL: https://4191592d.xmtp-js.pages.dev
Branch Preview URL: https://rygine-content-types.xmtp-js.pages.dev

View logs

Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

255 files touched. 😰 💦

@rygine rygine merged commit 95a8450 into main Oct 10, 2024
20 checks passed
@rygine rygine deleted the rygine/content-types branch October 10, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants