-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist private preferences to keystore #657
Merged
Merged
+481
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dafd1e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rygine
force-pushed
the
rygine/persist-consent
branch
from
September 5, 2024 21:37
7f6a0b0
to
cc5be9b
Compare
Deploying xmtp-js-docs with Cloudflare Pages
|
nplasterer
approved these changes
Sep 6, 2024
rygine
force-pushed
the
rygine/persist-consent
branch
from
September 6, 2024 15:50
859b37e
to
d3b13b7
Compare
rygine
force-pushed
the
rygine/persist-consent
branch
from
September 6, 2024 20:02
4343708
to
8b74f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds caching of private preferences to the JS SDK.
@xmtp/proto
for encoding of a private preferences action mapInMemoryKeystore
to interact with the private preferences storeContacts
class to use the private preferences storelastConsentListEntryTimestamp
method fromContacts
classNotes
for
loops rather thanfor..of
is intentional as it's more performant with a large number of iterations.persistConversations
option. I think they should be tied together and having a separate option would create unnecessary complexity.