Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct inbox ID for all environments #620

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jun 8, 2024

Summary

The inbox ID was being incorrectly calculated for the dev environment because hardcoded values were being used for the host and isSecure parameters.

@rygine rygine requested a review from a team June 8, 2024 20:18
Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: ff6c304

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/mls-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Jun 8, 2024

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff6c304
Status: ✅  Deploy successful!
Preview URL: https://a1083d36.xmtp-js.pages.dev
Branch Preview URL: https://rygine-fix-inbox-id.xmtp-js.pages.dev

View logs

@rygine rygine requested a review from humanagent as a code owner June 8, 2024 20:19
@rygine rygine merged commit c9254ac into main Jun 8, 2024
9 checks passed
@rygine rygine deleted the rygine/fix-inbox-id branch June 8, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants