Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce type specifier on imports and exports #546

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Mar 11, 2024

Summary

This PR adds a new lint rule that requires type imports and exports to be specified. The linter was able to auto-fix all errors resulting from this update.

For more info on this change, see https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/

Other updates

  • Updated tsconfig.json to include more files
  • Removed unnecessary ESLint comment disabling a rule
  • Increased test timeout to 2mins

No release required as these changes will not affect the bundle outputs.

@rygine rygine requested a review from a team March 11, 2024 23:23
Copy link

cloudflare-workers-and-pages bot commented Mar 11, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e621cee
Status: ✅  Deploy successful!
Preview URL: https://0da03102.xmtp-js.pages.dev
Branch Preview URL: https://rygine-update-imports-export.xmtp-js.pages.dev

View logs

@rygine rygine merged commit 687cd8a into main Mar 12, 2024
9 checks passed
@rygine rygine deleted the rygine/update-imports-exports branch March 12, 2024 02:10
Copy link
Contributor

🎉 This PR is included in version 11.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants