Migrate to yarn, vitest #539
Conversation
Deploying with
|
| Latest commit: |
c61360a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a95ee965.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-yarn.xmtp-js.pages.dev |
| import { BackupType } from '../src/message-backup/BackupClient' | ||
| import { newLocalHostClient, newDevClient } from './helpers' | ||
|
|
||
| describe('Backup configuration', () => { | ||
| it('Uses XMTP backup for localhost', async function () { | ||
| const c = await newLocalHostClient() | ||
| assert.equal(c.backupType, BackupType.xmtpTopicStore) |
There was a problem hiding this comment.
Good riddance to these. I think our use of assert actually predates my time at XMTP
| "@xmtp/user-preferences-bindings-wasm": "0.3.6", | ||
| "async-mutex": "0.4.0", | ||
| "elliptic": "6.5.4", | ||
| "ethers": "5.5.3", |
There was a problem hiding this comment.
I worry about these exact matches for common deps causing dependency bloat for integrators who use slightly different versions of common libraries like ethers
There was a problem hiding this comment.
this is a temporary measure to prevent issues when switching from NPM to yarn. once this PR merges, i'll start upgrading the dependencies with proper versions.
i'm OK keeping semantic release for now, but just as happy to switch to changesets. |
Mostly just curious. No urgency on making changes there. For a single package repo semantic release works just fine. |
|
🎉 This PR is included in version 11.3.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
~42s=>~12s)assertwithexpectdd-tracedependencytestworkflow, removeddd-tracefrom browser testingprettier-plugin-packagejsonThis PR updates the tooling of this repo to match our other TypeScript repos.