Replace ethers with viem
#528
Merged
+323
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Feb 7, 2024
Deploying with
|
| Latest commit: |
1a3500d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb18864c.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-ethers-to-viem.xmtp-js.pages.dev |
neekolas
approved these changes
Feb 7, 2024
rygine
force-pushed
the
rygine/ethers-to-viem
branch
2 times, most recently
from
036d78c to
74cc692
Compare
neekolas
reviewed
Feb 27, 2024
rygine
commented
Feb 27, 2024
| alice.conversations.newConversation(bobUpper) | ||
| ).resolves.toMatchObject({ | ||
| peerAddress: bob.address, | ||
| }) |
There was a problem hiding this comment.
an all uppercase address generates an error with viem so removed this test. the getAddress function runs through this bit of code before returning the checksum address. we could keep the test and update our code to always lowercase an address before generating a checksum address.
rygine
force-pushed
the
rygine/ethers-to-viem
branch
from
74cc692 to
72ab6db
Compare
neekolas
approved these changes
Feb 28, 2024
|
🎉 This PR is included in version 11.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR replaces the use of
etherswithviem. see Why Viem for more info on this change.