Update Keystore types #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rygine
commented
Jan 23, 2024
| if (codecs.req) { | ||
| const reqBytes = codecs.req.encode(req).finish() | ||
| if (rpc.req) { | ||
| const encoder = rpc.req.encode as SnapKeystoreApiRequestEncoders[T] |
There was a problem hiding this comment.
tsc needs an assist here to narrow the type
rygine
commented
Jan 23, 2024
| @@ -42,20 +53,21 @@ export async function snapRPC<Req, Res>( | |||
| throw new Error('Unexpected array response') | |||
| } | |||
|
|
|||
| return codecs.res.decode(b64Decode(responseString)) | |||
| const decoder = rpc.res.decode as SnapKeystoreApiResponseDecoders[T] | |||
There was a problem hiding this comment.
same as above: tsc needs an assist here to narrow the type
rygine
force-pushed
the
rygine/rpc-types
branch
from
da2aa99 to
d6c9d3b
Compare
Deploying with
|
| Latest commit: |
3ea9501
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c50eeb1.xmtp-js.pages.dev |
| Branch Preview URL: | https://rygine-rpc-types.xmtp-js.pages.dev |
rygine
force-pushed
the
rygine/rpc-types
branch
from
d6c9d3b to
2f67978
Compare
rygine
force-pushed
the
rygine/rpc-types
branch
from
2f67978 to
3ea9501
Compare
neekolas
approved these changes
Jan 23, 2024
|
🎉 This PR is included in version 11.3.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR:
Keystoreinterfacethese new types allow for a single source of truth for keystore functionality and their associated types. updating a keystore's RPC definitions will automatically update its types.
i decided to export all the derivative types as well so that integrators have them. they are invaluable for creating type-safe custom keystores and their handlers.