Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return DecodedMessage when sending PreparedMessage #467

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Oct 17, 2023

after sending a prepared message, there's no easy way to access the DecodedMessage of the sent message. this PR returns a DecodedMessage from the send method of a PreparedMessage.

@rygine rygine requested a review from a team October 17, 2023 18:17
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59fcac4
Status: ✅  Deploy successful!
Preview URL: https://78e62aaf.xmtp-js.pages.dev
Branch Preview URL: https://rygine-update-prepare-messag.xmtp-js.pages.dev

View logs

@rygine rygine force-pushed the rygine/update-prepare-message branch from 54233a2 to 59fcac4 Compare October 17, 2023 19:23
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bugs you spotted along the way

@rygine rygine merged commit 0980c94 into main Oct 17, 2023
7 checks passed
@rygine rygine deleted the rygine/update-prepare-message branch October 17, 2023 19:28
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants