Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support byte array messages with viem signer #460

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Sep 26, 2023

No description provided.

@rygine rygine requested a review from a team September 26, 2023 16:08
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd8e49a
Status: ✅  Deploy successful!
Preview URL: https://231bd198.xmtp-js.pages.dev
Branch Preview URL: https://rygine-viem-update.xmtp-js.pages.dev

View logs

Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test case using the signer with both a string and a Uint8Array

@rygine rygine merged commit ed4def6 into main Sep 26, 2023
7 checks passed
@rygine rygine deleted the rygine/viem-update branch September 26, 2023 19:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants