Viem Support #459
Merged
Viem Support #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
89fe00f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fa0d01e.xmtp-js.pages.dev |
| Branch Preview URL: | https://nmolnar-support-viem-signer.xmtp-js.pages.dev |
nplasterer
approved these changes
Sep 24, 2023
daria-github
approved these changes
Sep 25, 2023
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Devs are constantly complaining about the pains of using
xmtp-jswith Viem/Wagmi. This allows developers to use a ViemWalletClientinstead of anethers.Signer. This does that by converting theWalletClientinto aSigner.I had to upgrade eslint and a bunch of other dev dependencies to satisfy Viem's peer dependency on Typescript 5. That also forced me to fix some lint errors that were previously not getting caught.