Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Duplicate conversation issues due to case insensitive equality check #472

Closed
neekolas opened this issue Oct 25, 2023 · 0 comments · Fixed by #473
Closed

Bug: Duplicate conversation issues due to case insensitive equality check #472

neekolas opened this issue Oct 25, 2023 · 0 comments · Fixed by #473
Assignees
@rygine
Labels
bug Something isn't working

Comments

@neekolas
Copy link
Contributor

Describe the bug

A developer is experiencing duplicate conversations in v11. We believe it may be related to a case-insensitive check here: https://github.com/xmtp/xmtp-js/blob/main/src/conversations/Conversations.ts#L490

Expected behavior

Conversations are de-duplicated irrespective of wallet address capitalization

Steps to reproduce the bug

  1. Create a conversation with the address using standard checksum formatting
  2. Call client.conversations.newConversation with the same address lowercased
  3. Call client.conversations.list()

One conversation should be returned.
@neekolas neekolas added the bug Something isn't working label Oct 25, 2023
@rygine rygine linked a pull request Oct 25, 2023 that will close this issue
fix: use lowercase to compare addresses #473
Merged
@alexrisch alexrisch mentioned this issue Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rygine rygine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use lowercase to compare addresses xmtp/xmtp-js
2 participants
@neekolas @rygine