Merge pull request #694 from xmtp/rygine/node-sdk-updates

Update Node SDK

.changeset/chatty-snails-roll.md

@@ -0,0 +1,8 @@
+---
+"@xmtp/node-sdk": patch
+---
+
+- Allowed for `undefined` content type and content in messages
+- Filtered out messages without content when calling `Conversation.messages`
+- Added generic typing for message content to `DecodedMessage` class and `Conversations.findMessageById`
+- Replaced temporary group updated codec with official content type

sdks/node-sdk/package.json

@@ -48,6 +48,7 @@
     "typecheck": "tsc"
   },
   "dependencies": {
+    "@xmtp/content-type-group-updated": "^1.0.0",
     "@xmtp/content-type-primitives": "^1.0.2",
     "@xmtp/content-type-text": "^1.0.0",
     "@xmtp/node-bindings": "^0.0.14",

sdks/node-sdk/rollup.config.js

@@ -8,8 +8,9 @@ import tsConfigPaths from "rollup-plugin-tsconfig-paths";
 const external = [
   "node:path",
   "node:process",
-  "@xmtp/content-type-text",
+  "@xmtp/content-type-group-updated",
   "@xmtp/content-type-primitives",
+  "@xmtp/content-type-text",
   "@xmtp/node-bindings",
   "@xmtp/proto",
   "@xmtp/xmtp-js",

sdks/node-sdk/src/Client.ts

@@ -1,5 +1,9 @@
 import { join } from "node:path";
 import process from "node:process";
+import {
+  ContentTypeGroupUpdated,
+  GroupUpdatedCodec,
+} from "@xmtp/content-type-group-updated";
 import type {
   ContentCodec,
   ContentTypeId,
@@ -15,10 +19,6 @@ import {
   type NapiClient,
   type NapiMessage,
 } from "@xmtp/node-bindings";
-import {
-  ContentTypeGroupUpdated,
-  GroupUpdatedCodec,
-} from "@/codecs/GroupUpdatedCodec";
 import { Conversations } from "@/Conversations";
 
 export const ApiUrls = {

sdks/node-sdk/src/Conversation.ts

@@ -189,8 +189,12 @@ export class Conversation {
   }
 
   messages(options?: NapiListMessagesOptions): DecodedMessage[] {
-    return this.#group
-      .findMessages(options)
-      .map((message) => new DecodedMessage(this.#client, message));
+    return (
+      this.#group
+        .findMessages(options)
+        .map((message) => new DecodedMessage(this.#client, message))
+        // filter out messages without content
+        .filter((message) => message.content !== undefined)
+    );
   }
 }

sdks/node-sdk/src/Conversations.ts

@@ -27,11 +27,11 @@ export class Conversations {
     }
   }
 
-  getMessageById(id: string) {
+  getMessageById<T = any>(id: string) {
     try {
       // findMessageById will throw if message is not found
       const message = this.#conversations.findMessageById(id);
-      return new DecodedMessage(this.#client, message);
+      return new DecodedMessage<T>(this.#client, message);
     } catch {
       return null;
     }

sdks/node-sdk/src/DecodedMessage.ts

@@ -10,10 +10,10 @@ import { nsToDate } from "@/helpers/date";
 export type MessageKind = "application" | "membership_change";
 export type MessageDeliveryStatus = "unpublished" | "published" | "failed";
 
-export class DecodedMessage {
+export class DecodedMessage<T = any> {
   #client: Client;
-  content: any;
-  contentType: ContentTypeId;
+  content: T;
+  contentType: ContentTypeId | undefined;
   conversationId: string;
   deliveryStatus: MessageDeliveryStatus;
   fallback?: string;
@@ -56,12 +56,15 @@ export class DecodedMessage {
       // no default
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    this.contentType = new ContentTypeId(message.content.type!);
+    this.contentType = message.content.type
+      ? new ContentTypeId(message.content.type)
+      : undefined;
     this.parameters = message.content.parameters;
     this.fallback = message.content.fallback;
     this.compression = message.content.compression;
     // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-    this.content = this.#client.decodeContent(message, this.contentType);
+    this.content = this.contentType
+      ? this.#client.decodeContent(message, this.contentType)
+      : undefined;
   }
 }

sdks/node-sdk/src/index.ts

@@ -9,9 +9,5 @@ export { Client, ApiUrls } from "./Client";
 export { Conversation } from "./Conversation";
 export { Conversations } from "./Conversations";
 export { DecodedMessage } from "./DecodedMessage";
-export {
-  ContentTypeGroupUpdated,
-  GroupUpdatedCodec,
-} from "./codecs/GroupUpdatedCodec";
 export type { StreamCallback } from "./AsyncStream";
 export type * from "@xmtp/node-bindings";

yarn.lock

@@ -4847,6 +4847,7 @@ __metadata:
     "@rollup/plugin-typescript": "npm:^12.1.1"
     "@types/node": "npm:^20.16.12"
     "@vitest/coverage-v8": "npm:^2.1.3"
+    "@xmtp/content-type-group-updated": "npm:^1.0.0"
     "@xmtp/content-type-primitives": "npm:^1.0.2"
     "@xmtp/content-type-text": "npm:^1.0.0"
     "@xmtp/node-bindings": "npm:^0.0.14"