Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy improvements for forks #430

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Legacy improvements for forks #430

merged 5 commits into from
Nov 15, 2024

Conversation

nplasterer
Copy link
Contributor

This potentially fixes issues with forked groups
Also adds more protection for checksum addresses

@nplasterer nplasterer self-assigned this Nov 15, 2024
@nplasterer nplasterer marked this pull request as ready for review November 15, 2024 15:17
@nplasterer nplasterer requested a review from a team as a code owner November 15, 2024 15:17
@@ -205,7 +205,7 @@ extension FfiConversation {
}

func toConversation(client: Client) throws -> Conversation {
if (try groupMetadata().conversationType() == "dm") {
if (try conversationType() == .dm) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@nplasterer nplasterer merged commit d52c0bb into xmtp-legacy Nov 15, 2024
1 of 2 checks passed
@nplasterer nplasterer deleted the np/fork-fix branch November 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants