Fix stream cancelation cancels underlying stream #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm actually getting this error alot in a bunch of random tests
I don't think it's related to these changes but figured I'd flag it. Wonder if anyone else is seeing these when running the tests in XCode? |
|
I'm no longer seeing the double send for messages either. 🎉 |
alexrisch
approved these changes
Sep 2, 2024
alexrisch
approved these changes
Sep 2, 2024
neekolas
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after a stream was canceled the underlying stream was still streaming messages which was causing issues.
This officially cancels the stream and improves streams so only the stream messages are streamed once and not streamed when canceled