Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the error messages readable #370

Merged
merged 7 commits into from
Jul 24, 2024
+18 −4
Merged

Make the error messages readable #370

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2dc11f
make the error messages readable
nplasterer Jul 23, 2024
dcef0b2
Update tests.yml
nplasterer Jul 23, 2024
fa46d75
Update tests.yml
nplasterer Jul 23, 2024
821c8aa
add an install for rust
nplasterer Jul 23, 2024
6aa50e2
Update tests.yml
nplasterer Jul 23, 2024
ed2998e
another ci try
nplasterer Jul 24, 2024
2f38946
Merge branch 'np/make-error-messages-readable' of https://github.com/…
nplasterer Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Sources/XMTPiOS/Client.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import web3

public typealias PreEventCallback = () async throws -> Void

public enum ClientError: Error, CustomStringConvertible {
public enum ClientError: Error, CustomStringConvertible, LocalizedError {
case creationError(String)
case noV3Client(String)

Expand All @@ -23,6 +23,10 @@ public enum ClientError: Error, CustomStringConvertible {
return "ClientError.noV3Client: \(err)"
}
}

public var errorDescription: String? {
return description
}
}

/// Specify configuration options for creating a ``Client``.
Expand Down Expand Up @@ -128,7 +132,13 @@ public final class Client {
)
return try await create(account: account, apiClient: apiClient, options: options)
} catch {
throw ClientError.creationError("\(error)")
let detailedErrorMessage: String
if let nsError = error as NSError? {
detailedErrorMessage = nsError.description
} else {
detailedErrorMessage = error.localizedDescription
}
throw ClientError.creationError(detailedErrorMessage)
}
}

Expand Down
Loading