ConsentList Concurrency Crash #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrisch
approved these changes
Apr 17, 2024
|
|
||
| try await withThrowingTaskGroup(of: ConsentListEntry.self) { group in | ||
| for address in addresses { | ||
| group.addTask { |
There was a problem hiding this comment.
I gather that you want this to be serial as opposed to parallel.
As I read this, it looks like the inner for loop here will be executed in parallel. I think that the return await inside might cover it, but I'm suspicious.
If that's ok for this part of the operation, then you're good. The outer loop executions look to be serial. I would back it with a test to verify the order though. Stepping between serial & parallel executions can get a bit tricky and produce unexpected results.
zombieobject
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
Lets make the entries list a actor so that we don't accidentally try to modify the map at the same time. Likely causing this crash.