thirtyDayPeriodsSinceEpoch fix #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Mar 6, 2024
Comment on lines
+590
to
+591
| let daysSinceEpoch = Date().timeIntervalSince1970 / (60 * 60 * 24) | ||
| let thirtyDayPeriodsSinceEpoch = Int(floor(daysSinceEpoch / 30)) |
There was a problem hiding this comment.
JS divides also by 1000 every where but I think that might be a bug in JS @rygine
kele-leanes
approved these changes
Mar 6, 2024
|
Confirmed that iOS convert to int takes the floor so I actually don't think we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JS they do this
I think this brings the code closer inline with that.