Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete database follows ups #266

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Delete database follows ups #266

merged 3 commits into from
Feb 27, 2024

Conversation

nplasterer
Copy link
Contributor

Adds a test and fixes the implementation a bit.

@nplasterer nplasterer self-assigned this Feb 25, 2024
@nplasterer nplasterer marked this pull request as ready for review February 25, 2024 15:52
@nplasterer nplasterer requested a review from a team as a code owner February 25, 2024 15:52
cameronvoell
cameronvoell approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete db, new test look good 👍

@zombieobject zombieobject merged commit c851638 into main Feb 27, 2024
1 check passed
@zombieobject zombieobject deleted the np/delete-database-follow-ups branch February 27, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieobject zombieobject zombieobject approved these changes

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nplasterer @cameronvoell @zombieobject