Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin WalletConnectV2 & Add App Icon #255

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

zombieobject
Copy link
Contributor

@zombieobject zombieobject commented Feb 20, 2024

There are two minor fixes in this PR that both enable building the project and add some visual improvements.

  • Currently the Sample App doesn't build due to recent updates to the dependency WalletConnectV2. Pinning this Swift Package to the version that was released when added fixes this issue. In future releases, we will update the Sample App code to adopt the latest API Interface.
  • The Sample App doesn't have an App Icon. While this isn't an issue for local development, it needs to be addressed to improve the visible quality of our SDK to public consumers.

Note: Tests were not included as part of this PR and are out of scope. Overall SDK Test Suites will be re-enabled in a future pull request.

@zombieobject zombieobject added bug Something isn't working enhancement New feature or request labels Feb 20, 2024
@zombieobject zombieobject self-assigned this Feb 20, 2024
@zombieobject zombieobject requested a review from a team as a code owner February 20, 2024 00:44
@zombieobject zombieobject merged commit 8654a14 into main Feb 20, 2024
1 check passed
@zombieobject zombieobject deleted the fixes/SampleApp-Fixes branch February 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants