Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Admin Permissions #253

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Group Admin Permissions #253

merged 5 commits into from
Feb 20, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Feb 16, 2024

Fixes canMessage returns correctly for a list of addresses.
Adds group admin permissions

@nplasterer nplasterer self-assigned this Feb 16, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 16, 2024 23:30
@nplasterer nplasterer changed the title Fix: Can message returns correctly Group Admin Permissions Feb 19, 2024

func testCanCreateAGroupWithAdminPermissions() async throws {
let fixtures = try await localFixtures()
let bobGroup = try await fixtures.bobClient.conversations.newGroup(with: [fixtures.alice.address], permissions: GroupPermissions.groupCreatorIsAdmin)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCode is giving me Extra argument 'permissions' in call @zombieobject am I doing this wrong?

Copy link
Contributor

@zombieobject zombieobject Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nplasterer I was heads down working on fixing the tests for libXMTPSwift and XMPT-iOS when this came in. I don't see the error any longer using the HEAD from this branch. The interface method resolves correctly from I can tell at this point. Has this been resolved already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have just been an xcode issue. 🤔 The tests did pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode has been showing ghost errors from time to time since version 14.3. 🙄 When they get too annoying, I temporarily disable "Show Live Issues" in Settings->General until I move onto the next task.

Copy link
Contributor

@zombieobject zombieobject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, I am very much looking forward to passing tests! TYSM! 🙂

@zombieobject zombieobject merged commit 56310bc into main Feb 20, 2024
1 check passed
@zombieobject zombieobject deleted the np/fix-can-message branch February 20, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants