-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Admin Permissions #253
Conversation
|
||
func testCanCreateAGroupWithAdminPermissions() async throws { | ||
let fixtures = try await localFixtures() | ||
let bobGroup = try await fixtures.bobClient.conversations.newGroup(with: [fixtures.alice.address], permissions: GroupPermissions.groupCreatorIsAdmin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XCode is giving me Extra argument 'permissions' in call
@zombieobject am I doing this wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nplasterer I was heads down working on fixing the tests for libXMTPSwift and XMPT-iOS when this came in. I don't see the error any longer using the HEAD from this branch. The interface method resolves correctly from I can tell at this point. Has this been resolved already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must have just been an xcode issue. 🤔 The tests did pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xcode has been showing ghost errors from time to time since version 14.3
. 🙄 When they get too annoying, I temporarily disable "Show Live Issues" in Settings->General
until I move onto the next task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, I am very much looking forward to passing tests! TYSM! 🙂
Fixes canMessage returns correctly for a list of addresses.
Adds group admin permissions