Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in groups file #243

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix typo in groups file #243

merged 1 commit into from
Feb 9, 2024

Conversation

nplasterer
Copy link
Contributor

Cocoapods returning

    - ERROR | [iOS] xcodebuild:  /Users/runner/work/xmtp-ios/xmtp-ios/Sources/XMTPiOS/Group.swift:12:14: error: cannot find type 'XMTPiOS' in scope
    - ERROR | [iOS] xcodebuild:  /Users/runner/work/xmtp-ios/xmtp-ios/Sources/XMTPiOS/Group.swift:15:15: error: cannot find type 'XMTPiOS' in scope

We shouldn't need the name spacing on XMTPiOS here

@nplasterer nplasterer self-assigned this Feb 9, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 9, 2024 17:41
cameronvoell
cameronvoell approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 looks good now on RN

@nplasterer nplasterer merged commit 64f9e97 into main Feb 9, 2024
1 check passed
@nplasterer nplasterer deleted the np/typo-in-file branch February 9, 2024 17:57
kele-leanes pushed a commit that referenced this pull request Feb 19, 2024
@nplasterer
fix typo in groups file (#243)
5d4ad1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @cameronvoell