Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update to WalletConnectSwiftV2 until we resolve errors #242

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Feb 9, 2024

WalletConnectSwiftV2 was updated in Example project Package.resolved in this PR and it broke the example project.

We should not update this until we fix errors from the WalletConnectSwiftV2 update.

To Test

  1. Verify that Example project can not be built on main
  2. checkout cv/fix-example-project and verify that the example project can now be built

@cameronvoell cameronvoell marked this pull request as ready for review February 9, 2024 14:54
@cameronvoell cameronvoell requested a review from a team as a code owner February 9, 2024 14:54
@cameronvoell cameronvoell merged commit e1ada39 into main Feb 9, 2024
1 check passed
@cameronvoell cameronvoell deleted the cv/fix-example-project branch February 9, 2024 14:57
kele-leanes pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants