V3 group streaming #239
Merged
V3 group streaming #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Feb 7, 2024
| @@ -48,6 +63,18 @@ public actor Conversations { | |||
| return try await v3Client.conversations().list(opts: options).map { $0.fromFFI(client: client) } | |||
| } | |||
|
|
|||
| public func streamGroups() async throws -> AsyncThrowingStream<Group, Error> { | |||
There was a problem hiding this comment.
I'm not sure how you're going to stream both groups and conversations at the same time. But to be able to do this in Android the stream had to return the same type.
There was a problem hiding this comment.
Currently planning on holding off on having a combined stream until we do the Conversation -> DM rename. Then we can just have that stream return the union.
…into v3-group-streaming
nakajima
added a commit
that referenced
this pull request
Feb 8, 2024
* Introduce group chat to xmtp-ios * fix lint, add address to example app for groups * paginate * Handle membership changes in example app * Make syncing explicit * Pass legacySignedPrivateKeyProto * add more validations * Add ClientOptions.enableAlphaMLS * Make group changes codec opt-in * Point to libxmtp-swift package, not local filesystem * Update Package.swift Co-authored-by: Cameron Voell <[email protected]> * bump podspec * include env in db url * extract method * return members as strings not objects * Error when trying to enable alpha MLS with no signer and no keys * pass encryption key * Move client test to clientests * Pull v3 client into its own PR * Update GroupMembershipChanged.swift * Add tests * rename mls alpha * fix codec * cleanup * Fix example app (needed to add manual syncs) * Update GroupMembershipChanged.swift * fix nav * cleanup * add group settings view * rename members to member addresses * uncomment local node skip * improve group error * use group id for topic * fix lint * allow mls on dev, other cleanup * V3 group streaming (#239) * ui updates, fix lint * Add streaming * use convo id * bump podspec * bump podspec --------- Co-authored-by: Cameron Voell <[email protected]>
kele-leanes
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Introduce group chat to xmtp-ios * fix lint, add address to example app for groups * paginate * Handle membership changes in example app * Make syncing explicit * Pass legacySignedPrivateKeyProto * add more validations * Add ClientOptions.enableAlphaMLS * Make group changes codec opt-in * Point to libxmtp-swift package, not local filesystem * Update Package.swift Co-authored-by: Cameron Voell <[email protected]> * bump podspec * include env in db url * extract method * return members as strings not objects * Error when trying to enable alpha MLS with no signer and no keys * pass encryption key * Move client test to clientests * Pull v3 client into its own PR * Update GroupMembershipChanged.swift * Add tests * rename mls alpha * fix codec * cleanup * Fix example app (needed to add manual syncs) * Update GroupMembershipChanged.swift * fix nav * cleanup * add group settings view * rename members to member addresses * uncomment local node skip * improve group error * use group id for topic * fix lint * allow mls on dev, other cleanup * V3 group streaming (#239) * ui updates, fix lint * Add streaming * use convo id * bump podspec * bump podspec --------- Co-authored-by: Cameron Voell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #229.