Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network links #234

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Update network links #234

merged 4 commits into from
Feb 6, 2024

Conversation

nplasterer
Copy link
Contributor

Fixes #185

We had a small issue in how streaming was working in the backend. This should fix that.

@nplasterer nplasterer requested a review from neekolas February 6, 2024 15:34
@nplasterer nplasterer self-assigned this Feb 6, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 6, 2024 15:34
Copy link
Contributor Author

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I can't approve this. Can you bump the pod spec and document the breaking change/upgrade integrators will need to do?

Seems like just GRPCApiClient.envToUrl(env: .local) to XMTPEnvironment.local.url, in their code.

@nplasterer nplasterer merged commit fb8adfe into main Feb 6, 2024
1 check passed
@nplasterer nplasterer deleted the np/update-links branch February 6, 2024 17:54
kele-leanes pushed a commit that referenced this pull request Feb 19, 2024
* update the links to point to new more performant endpoints

* update the urls as well

* remove envToUrl

* bump podspec

---------

Co-authored-by: Pat Nakajima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Stream disconnects on App Backgrounding
4 participants