make canMessage method accessible on the Client class #200
Conversation
Tests/XMTPTests/ClientTests.swift
Outdated
| try TestConfig.skip(because: "run manually against dev") | ||
| let opts = ClientOptions(api: ClientOptions.Api(env: .local, isSecure: false)) |
There was a problem hiding this comment.
It seems like this is running against local not dev?
| try TestConfig.skip(because: "run manually against dev") | |
| let opts = ClientOptions(api: ClientOptions.Api(env: .local, isSecure: false)) | |
| try TestConfig.skip(because: "run manually against local") | |
| let opts = ClientOptions(api: ClientOptions.Api(env: .local, isSecure: false)) |
There was a problem hiding this comment.
if you run the test locally you will get the following error:
error: -[XMTPTests.ClientTests testStaticCanMessage] : failed: caught error: "creationError("setup error")"
you should run it pointing to dev to pass the test
There was a problem hiding this comment.
You're pointing at the local network here so it's definitely running on local. When I have the local network running in docker on my computer and run this test it passes when I kill the local server it fails. Just want to make it clear this is not running on dev (which is good we want it running on local since it's a test). We should still keep the test skipped as iOS CI can't run a local server but I think the wording of dev is misleading in this instance. I'm pushing up a fix for that and some spacing issues. 🙏
|
@kele-leanes This is looking good you mind bumping the pod spec like I did here: #193 So that you can pick up these changes in React Native 🙏 |
This PR exposes the
canMessagemethod as requested in this comment