Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WalletConnect V2 implementation via Web3Modal Flutter SDK #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Babak-gh
Copy link

Fix #88 with implementing WalletConnect V2 via Web3Modal Flutter SDK

Copy link
Contributor

@dmccartney dmccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on this upgrade this looks great.

It looks like the build is failing because of a dependency issue with http and dart:

Resolving dependencies in ./example...
The current Dart SDK version is 3.1.5.
Because example depends on http >=1.1.1 which requires SDK version >=3.2.0 <4.0.0, version solving failed.

Assuming the example needs that version of http, I think the fix for that is to specify the newer flutter version in the CI workflows to get the newer dart SDK. Right now they all use flutter-version: '3.13.9' but we should update to use one of the more recent stable versions that include the newer dart SDK:

  • ✂️ flutter-version: '3.13.9'
  • flutter-version: '3.16.9'

(Separately, we should probably update the environment: in example/pubspec.yaml to match the environment: in the primary pubspec.yaml to keep it accurate.)

@Babak-gh
Copy link
Author

Babak-gh commented Feb 6, 2024

@dmccartney Would you please take a look at the failed check. I'm curious about the reason. Is it sth with my last commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The example application doesn't connect with the metamask wallet...
2 participants