Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance follow ups #355

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Performance follow ups #355

merged 6 commits into from
Dec 19, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Dec 19, 2024 •
edited
Loading

Add xmtpAPIClient for inboxId
MemCache the apiClient for the integrator

Before

Message Duration
Created a client 1.61s
Built a client 0.886s
Built a client with inboxId 0.41s
Built a client with inboxId and apiClient 0.111s

After

Message Time Taken
Created a client 1.168s
Built a client 0.255s
Built a client with inboxId 0.133s
Create a client after prebuilding apiClient 0.673s

@nplasterer nplasterer self-assigned this Dec 19, 2024
@nplasterer nplasterer marked this pull request as ready for review December 19, 2024 16:45
@nplasterer nplasterer requested a review from a team as a code owner December 19, 2024 16:45
@nplasterer nplasterer merged commit f06a0cd into main Dec 19, 2024
4 of 5 checks passed
@nplasterer nplasterer deleted the np/perf-follow-ups branch December 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @cameronvoell