Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up build client performance #354

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Speed up build client performance #354

merged 5 commits into from
Dec 18, 2024

Conversation

nplasterer
Copy link
Contributor

Much much faster now by passing in the apiClient.

Message Duration
Created a client 1.61s
Built a client 0.886s
Built a client with inboxId 0.41s
Built a client with inboxId and apiClient 0.111s

@nplasterer nplasterer self-assigned this Dec 18, 2024
@nplasterer nplasterer requested a review from a team as a code owner December 18, 2024 05:09
@nplasterer nplasterer requested a review from a team as a code owner December 18, 2024 06:20
cameronvoell
cameronvoell approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint warning to remove an extra break line

awesome performance improvement!

@nplasterer nplasterer merged commit de8949b into main Dec 18, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/client-create-perf branch December 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @cameronvoell