Libxmtp fork fix dont overwrite intent state #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
commented
Dec 16, 2024
| @@ -129,7 +129,8 @@ data class Conversations( | |||
|
|
|||
| // Sync all new and existing conversations data from the network | |||
| suspend fun syncAllConversations(): UInt { | |||
| return ffiConversations.syncAllConversations() | |||
| // TODO: add consentState here | |||
| return ffiConversations.syncAllConversations(null) | |||
There was a problem hiding this comment.
@nplasterer per conversation we'll add this in a follow up. or let me know if I misunderstood
cameronvoell
force-pushed
the
cv/update-libxmtp-fork-fix-published-intents
branch
from
a5f8cfe to
4f6359c
Compare
nplasterer
approved these changes
Dec 16, 2024
cameronvoell
deleted the
cv/update-libxmtp-fork-fix-published-intents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See xmtp/libxmtp#1416