[V3] Remove the ability to create a V2 client #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Nov 4, 2024
| ) | ||
| } | ||
|
|
||
| suspend fun canMessage(peerAddress: String, options: ClientOptions? = null): Boolean { |
There was a problem hiding this comment.
Maybe it would be helpful for people to still be able to use this to see if someone is on V2 if canMessageV3 returns false? They can't do much with that information tho since they can't actually message or create in V2.
codabrink
reviewed
Nov 6, 2024
| @@ -134,7 +133,7 @@ sealed class Conversation { | |||
| limit: Int? = null, | |||
| before: Date? = null, | |||
| after: Date? = null, | |||
| direction: PagingInfoSortDirection = MessageApiOuterClass.SortDirection.SORT_DIRECTION_DESCENDING, | |||
codabrink
reviewed
Nov 6, 2024
| // val digest = MessageDigest.getInstance("SHA-256") | ||
| // return digest.digest(input) | ||
| // } | ||
| //} |
There was a problem hiding this comment.
Do we want to just delete this?
codabrink
approved these changes
Nov 6, 2024
* get all the tests compiling * fix up the wallet address * more clean up * get all the tests passing * make the ffiClient private so people dont call it directly * [V3] Update example app (#317) * update the example to be v3 only * remove force * remove some impots
nplasterer
added a commit
that referenced
this pull request
Nov 7, 2024
* remove contacts and rename to preferences * [V3] Remove the ability to create a V2 client (#315) * remove the ability to create a v2 client entirely * remove a bunch of classes no longer needed * [V3] Fix up all the tests (#316) * get all the tests compiling * fix up the wallet address * more clean up * get all the tests passing * make the ffiClient private so people dont call it directly * [V3] Update example app (#317) * update the example to be v3 only * remove force * remove some impots * update frames * clean up the code * rename and fix up the lint
nplasterer
added a commit
that referenced
this pull request
Nov 7, 2024
* remove decrypted messages and only use decoded * [V3] Remove contacts and rename to preferences (#314) * remove contacts and rename to preferences * [V3] Remove the ability to create a V2 client (#315) * remove the ability to create a v2 client entirely * remove a bunch of classes no longer needed * [V3] Fix up all the tests (#316) * get all the tests compiling * fix up the wallet address * more clean up * get all the tests passing * make the ffiClient private so people dont call it directly * [V3] Update example app (#317) * update the example to be v3 only * remove force * remove some impots * update frames * clean up the code * rename and fix up the lint
Merged
nplasterer
added a commit
that referenced
this pull request
Nov 7, 2024
* remove v1 and v2 conversations * update all the tests to compile * [V3] Remove Decrypted Messages (#313) * remove decrypted messages and only use decoded * [V3] Remove contacts and rename to preferences (#314) * remove contacts and rename to preferences * [V3] Remove the ability to create a V2 client (#315) * remove the ability to create a v2 client entirely * remove a bunch of classes no longer needed * [V3] Fix up all the tests (#316) * get all the tests compiling * fix up the wallet address * more clean up * get all the tests passing * make the ffiClient private so people dont call it directly * [V3] Update example app (#317) * update the example to be v3 only * remove force * remove some impots * update frames * clean up the code * rename and fix up the lint * fix up the lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major clean up removing all the V2 files from the code