Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Remove Decrypted Messages #313

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

nplasterer
Copy link
Contributor

Decrypted messages were added to help bridge the gap for React Native and custom content types. But over time they become nearly identical to decoded messages. Lets clean this up and just use decoded messages.

@nplasterer nplasterer self-assigned this Nov 3, 2024
@nplasterer nplasterer marked this pull request as ready for review November 6, 2024 04:45
@nplasterer nplasterer requested a review from a team as a code owner November 6, 2024 04:45
Copy link
Contributor

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup 🎉

* remove contacts and rename to preferences

* [V3] Remove the ability to create a V2 client (#315)

* remove the ability to create a v2 client entirely

* remove a bunch of classes no longer needed

* [V3] Fix up all the tests (#316)

* get all the tests compiling

* fix up the wallet address

* more clean up

* get all the tests passing

* make the ffiClient private so people dont call it directly

* [V3] Update example app (#317)

* update the example to be v3 only

* remove force

* remove some impots

* update frames

* clean up the code

* rename and fix up the lint
@nplasterer nplasterer merged commit 2d4db06 into np/v3 Nov 7, 2024
1 of 3 checks passed
@nplasterer nplasterer deleted the np/remove-decrypted-message branch November 7, 2024 01:33
nplasterer added a commit that referenced this pull request Nov 7, 2024
* remove v1 and v2 conversations

* update all the tests to compile

* [V3] Remove Decrypted Messages (#313)

* remove decrypted messages and only use decoded

* [V3] Remove contacts and rename to preferences (#314)

* remove contacts and rename to preferences

* [V3] Remove the ability to create a V2 client (#315)

* remove the ability to create a v2 client entirely

* remove a bunch of classes no longer needed

* [V3] Fix up all the tests (#316)

* get all the tests compiling

* fix up the wallet address

* more clean up

* get all the tests passing

* make the ffiClient private so people dont call it directly

* [V3] Update example app (#317)

* update the example to be v3 only

* remove force

* remove some impots

* update frames

* clean up the code

* rename and fix up the lint

* fix up the lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants