Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose timestamp on installations and make members async #300

Merged
merged 20 commits into from
Sep 26, 2024

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Sep 20, 2024

To make revoking installation keys more useful lets also expose when the installation was created at. This however requires members to be an async function now.

@codabrink codabrink requested a review from a team as a code owner September 20, 2024 13:39
@codabrink codabrink marked this pull request as draft September 20, 2024 13:45
@codabrink codabrink changed the title Members is now async and takes a client param Members is now async Sep 20, 2024
@codabrink codabrink changed the title Members is now async Members is now async to be able to recover from bad data Sep 20, 2024
@codabrink codabrink force-pushed the coda/group-members-async branch from 5af35d4 to 5ca58fb Compare September 20, 2024 20:07
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need some work. Can show you this week how to run them.

@nplasterer nplasterer changed the title Members is now async to be able to recover from bad data Expose timestamp on installations and make members async Sep 26, 2024
@nplasterer nplasterer marked this pull request as ready for review September 26, 2024 04:26
@nplasterer nplasterer requested a review from a team as a code owner September 26, 2024 04:26
@nplasterer nplasterer merged commit 1bc5bdc into main Sep 26, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the coda/group-members-async branch September 26, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants