-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose timestamp on installations and make members async #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codabrink
changed the title
Members is now async and takes a client param
Members is now async
Sep 20, 2024
codabrink
changed the title
Members is now async
Members is now async to be able to recover from bad data
Sep 20, 2024
codabrink
force-pushed
the
coda/group-members-async
branch
from
September 20, 2024 20:07
5af35d4
to
5ca58fb
Compare
nplasterer
reviewed
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests need some work. Can show you this week how to run them.
example/src/main/java/org/xmtp/android/example/conversation/ConversationViewHolder.kt
Outdated
Show resolved
Hide resolved
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
nplasterer
changed the title
Members is now async to be able to recover from bad data
Expose timestamp on installations and make members async
Sep 26, 2024
neekolas
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make revoking installation keys more useful lets also expose when the installation was created at. This however requires members to be an async function now.